Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix ExtMap.get with default value ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27660/1/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java: Line 323 Line 324 Line 325 Line 326 Line 327 > please check this as well Sure, I checked all the usages of the above method. I see it is used called from get(ExtKey key, Class<T> type) Do you really think that specifying the type besides the type that is associated with the ExtKey is needed? where will I want to to use that? -- To view, visit http://gerrit.ovirt.org/27660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9d04c4650ff0a01866ffd7edf2cce6801d422a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
