Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: use db creds from answer file ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27693/1/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py File packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py: Line 111 Line 112 Line 113 Line 114 Line 115 > so you need this one as well. Done? Line 121: (odwhcons.DBEnv.USER, 'DWH_DB_USER'), Line 122: (odwhcons.DBEnv.PASSWORD, 'DWH_DB_PASSWORD'), Line 123: (odwhcons.DBEnv.DATABASE, 'DWH_DB_DATABASE'), Line 124: ): Line 125: dbenv[e] = config.get(k, self.environment.get(e)) > I do not understand... if you go this route environment should override the Done Line 126: for e, k in ( Line 127: (odwhcons.DBEnv.SECURED, 'DWH_DB_SECURED'), Line 128: ( Line 129: odwhcons.DBEnv.SECURED_HOST_VALIDATION, -- To view, visit http://gerrit.ovirt.org/27693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icac431a840c1207313c5a4b6e47eace93d1dd099 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
