Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: use db creds from answer file ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27693/2/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py File packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py: Line 112: odwhcons.FileLocations.OVIRT_ENGINE_DWHD_SERVICE_CONFIG_DEFAULTS, Line 113: odwhcons.FileLocations.OVIRT_ENGINE_DWHD_SERVICE_CONFIG, Line 114: ]) Line 115: if ( Line 116: config.get('DWH_DB_PASSWORD') or > yes, you have +1, we just need to consider this ok, noted to myself Line 117: self.environment.get(odwhcons.DBEnv.PASSWORD) Line 118: ): Line 119: try: Line 120: dbenv = {} -- To view, visit http://gerrit.ovirt.org/27693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icac431a840c1207313c5a4b6e47eace93d1dd099 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
