Yair Zaslavsky has posted comments on this change. Change subject: engine : Add quartz to handle AsycCommands ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/28160/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 43: new Object[]{}, Config.<Integer>getValue(ConfigValues.AsyncCommandPollingRate), Line 44: Config.<Integer>getValue(ConfigValues.AsyncCommandPollingRate), TimeUnit.SECONDS); Line 45: } Line 46: Line 47: @OnTimerMethodAnnotation("_timer_Elapsed") i know it's copy paste from async task mgr, but still, no _ please :) Line 48: public synchronized void _timer_Elapsed() { Line 49: clearSucceededCommands(); Line 50: if (thereAreCommandsToPoll()) { Line 51: for (Guid cmdId : cmdCallBackMap.keySet()) { http://gerrit.ovirt.org/#/c/28160/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java: Line 4: import org.ovirt.engine.core.compat.Guid; Line 5: Line 6: public interface CommandCallBack { Line 7: public abstract void setExecutionResult(VdcReturnValueBase result); Line 8: public abstract void checkUpdateCmdStatus(Guid cmdId); maybe instead of checkXXXX have explicit methods of onSomeCmdStatus ? http://gerrit.ovirt.org/#/c/28160/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 47: select fn_db_add_config_value('AllowClusterWithVirtGlusterEnabled','true','general'); Line 48: select fn_db_add_config_value('AllowDuplicateMacAddresses','false','general'); Line 49: select fn_db_add_config_value('ApplicationMode','255','general'); Line 50: select fn_db_add_config_value('AsyncTaskPollingRate','10','general'); Line 51: select fn_db_add_config_value('AsyncCommandPollingRate','10','general'); please move this above AsyncTaskPollingRate Line 52: select fn_db_add_config_value('AsyncTaskStatusCacheRefreshRateInSeconds','30','general'); Line 53: select fn_db_add_config_value('AsyncTaskStatusCachingTimeInMinutes','1','general'); Line 54: select fn_db_add_config_value('AsyncTaskZombieTaskLifeInMinutes','300','general'); Line 55: select fn_db_add_config_value('AuditLogAgingThreshold','30','general'); -- To view, visit http://gerrit.ovirt.org/28160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1e5945884aec412ba412e39266129004d7218 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
