Ravi Nori has posted comments on this change. Change subject: engine : Add quartz to handle AsycCommands ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28160/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java: Line 4: import org.ovirt.engine.core.compat.Guid; Line 5: Line 6: public interface CommandCallBack { Line 7: public abstract void setExecutionResult(VdcReturnValueBase result); Line 8: public abstract void checkUpdateCmdStatus(Guid cmdId); > maybe instead of checkXXXX have explicit methods of onSomeCmdStatus ? This is a means to provide a way for the CallBack method to execute custom code and update the status of the command. Do you prefer the following? doPolling(Guid cmdId) onSuccess(Guid cmdId) onFailure(GuidCmdId) -- To view, visit http://gerrit.ovirt.org/28160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1e5945884aec412ba412e39266129004d7218 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
