Liron Ar has posted comments on this change. Change subject: core: synchronize pool storage domain operations ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25190/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java: Line 109: setSucceeded(true); Line 110: } Line 111: Line 112: private void refreshAllVdssInPool() { Line 113: final List<Guid> vdsIdsToSetNonOperational = new ArrayList<Guid>(); I'm not sure that we are completely there, the refresh will occur in the pool, but the metadata change is outside the queue, so while this refresh run the metadata could be changed by another operations leading to inconsistency - so having only the refresh in the queue doesn't seem good enough yet. in general i think that all pool metadata changes related operations with an exclusive lock (now implemented by the event queue) with the hosts refresh/connect operations under a shared lock (which currently isn't supported by the event queue..those operations are now serialized, which should be solved regardless). Line 114: Line 115: ((EventQueue) EjbUtils.findBean(BeanType.EVENTQUEUE_MANAGER, BeanProxyType.LOCAL)).submitEventSync( Line 116: new Event(getParameters().getStoragePoolId(), getParameters().getStorageDomainId(), null, EventType.POOLREFRESH, ""), Line 117: new Callable<EventResult>() { -- To view, visit http://gerrit.ovirt.org/25190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2d90d9589181802a2722b0e841a6342af0a807c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
