Liron Ar has posted comments on this change. Change subject: core: synchronize pool storage domain operations ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/25190/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java: Line 117: new Callable<EventResult>() { Line 118: @Override Line 119: public EventResult call() { Line 120: runSynchronizeOperation(new RefreshPoolSingleAsyncOperationFactory(), vdsIdsToSetNonOperational); Line 121: return null; in other cases don't we return an event result and not null? Line 122: } Line 123: } Line 124: ); Line 125: -- To view, visit http://gerrit.ovirt.org/25190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2d90d9589181802a2722b0e841a6342af0a807c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
