Alon Bar-Lev has posted comments on this change. Change subject: hooks: Adding hooks for ovirt-node-upgrade ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/28251/2/hooks/pre-upgrade/01-vdsm File hooks/pre-upgrade/01-vdsm: any reason this is not .py? Line 1: #!/usr/bin/python Line 2: # -*- coding: utf-8 -*- Line 3: # Line 4: # 01-vdsm - Copyright (C) 2014 Red Hat, Inc. http://gerrit.ovirt.org/#/c/28251/2/ovirt-node-plugin-vdsm.spec.in File ovirt-node-plugin-vdsm.spec.in: Line 50: make install DESTDIR=%{buildroot} Line 51: Line 52: # hooks to ovirt-node-upgrade Line 53: install -Dm 0755 hooks/pre-upgrade/01-vdsm \ Line 54: %{buildroot}%{_libexecdir}/ovirt-node/hooks/pre-upgrade/01-vdsm why isn't this part of make install? Line 55: Line 56: Line 57: %post Line 58: # reserve vdsm port 54321 -- To view, visit http://gerrit.ovirt.org/28251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986fe6edb8f5619dcbca33cccab080245654fd02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
