Alon Bar-Lev has posted comments on this change. Change subject: hooks: Adding hooks for ovirt-node-upgrade ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/28251/4/hooks/pre-upgrade/01-vdsm.py File hooks/pre-upgrade/01-vdsm.py: Line 22: sudo=True, Line 23: raw=True Line 24: ) Line 25: if rc != 0: Line 26: print("Error stopping vdsm daemon: %s" % err) to stderr? print also stdout? Line 27: Line 28: return rc Line 29: Line 30: if __name__ == "__main__": http://gerrit.ovirt.org/#/c/28251/4/ovirt-node-plugin-vdsm.spec.in File ovirt-node-plugin-vdsm.spec.in: Line 72: %{recipe_root} Line 73: Line 74: %files Line 75: %{python_sitelib}/ovirt/node/setup/vdsm Line 76: %{_libexecdir}/ovirt-node/hooks/pre-upgrade/01-vdsm.* make sure it won't be executed twice... once for the .py and the other for the .pyc Line 77: %{_sysconfdir}/ovirt-plugins.d Line 78: Line 79: %changelog Line 80: * Fri May 17 2013 Mike Burns <[email protected]> 0.0.2 -- To view, visit http://gerrit.ovirt.org/28251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986fe6edb8f5619dcbca33cccab080245654fd02 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
