Liron Ar has posted comments on this change. Change subject: core: Introducing HttpImageTaskVDSCommand ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26674/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java: Line 134: vdsStatic.getPort(), Line 135: "", Line 136: Config.<Boolean> getValue(ConfigValues.EncryptHostCommunication)); Line 137: Line 138: method = concreteCreateMethod(urlInfo.getFirst()); > Are you sure urlinfo can not be null? When can we get MalformedURLException yes, you get it from a host that it already used by the system Line 139: } Line 140: Line 141: return method; Line 142: } http://gerrit.ovirt.org/#/c/26674/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UploadStreamVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UploadStreamVDSCommand.java: Line 38 Line 39 Line 40 Line 41 Line 42 > don't we need this? or was it redundant in the first place unneeded, there's a logger defined higher in the hierarchy. -- To view, visit http://gerrit.ovirt.org/26674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc9284e62f75cc4958909bcb03c9b4fa8e30d7d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
