Gilad Chaplik has posted comments on this change. Change subject: common: introduce qos package, and storage qos ......................................................................
Patch Set 5: (5 comments) http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java: Line 14: /** Line 15: * Base abstract class for QoS objects Line 16: * Line 17: */ Line 18: public abstract class BaseQos extends IVdcQueryable implements BusinessEntity<Guid>, Serializable { > since it's a long patch-set, I will do the renaming at the last patch. Done Line 19: private static final long serialVersionUID = 1122772549710787678L; Line 20: private Guid id = Guid.Empty; Line 21: private QosType qoSType; Line 22: Line 20: private Guid id = Guid.Empty; Line 21: private QosType qoSType; Line 22: Line 23: @NotNull(message = "ACTION_TYPE_FAILED_NETWORK_QOS_INVALID_DC_ID") Line 24: private Guid storagePoolId; > Done will follow devel list discussion. Line 25: Line 26: @NotNull(message = "QOS_NAME_NOT_NULL") Line 27: @Size(min = 1, max = BusinessEntitiesDefinitions.GENERAL_NAME_SIZE, message = "QOS_NAME_TOO_LONG") Line 28: @ValidI18NName(message = "QOS_NAME_INVALID") Line 31: private BaseQos() { Line 32: } Line 33: Line 34: public BaseQos(QosType qoSType) { Line 35: this(); > Done added @SuppressWarnings("unused") to default c'tor instead Line 36: this.qoSType = qoSType; Line 37: } Line 38: /** Line 39: * @return object's type http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java: Line 6: Line 7: public enum QosType implements Identifiable { Line 8: STORAGE(1); Line 9: Line 10: private int value; > will re-consider. Done Line 11: private static final HashMap<Integer, QosType> valueToStatus = new HashMap<Integer, QosType>(); Line 12: Line 13: static { Line 14: for (QosType status : values()) { Line 9: Line 10: private int value; Line 11: private static final HashMap<Integer, QosType> valueToStatus = new HashMap<Integer, QosType>(); Line 12: Line 13: static { > will re-consider. try it out, apparently REST tests fails in your approach, the code should be static. Line 14: for (QosType status : values()) { Line 15: valueToStatus.put(status.getValue(), status); Line 16: } Line 17: } -- To view, visit http://gerrit.ovirt.org/27093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
