Moti Asayag has posted comments on this change. Change subject: common: introduce qos package, and storage qos ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27093/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java: Line 7: public enum QosType implements Identifiable { Line 8: STORAGE(1); Line 9: Line 10: private int value; Line 11: private static final HashMap<Integer, QosType> valueToStatus = new HashMap<Integer, QosType>(); could you reduce the type to Map ? Line 12: Line 13: static { Line 14: for (QosType status : values()) { Line 15: valueToStatus.put(status.getValue(), status); -- To view, visit http://gerrit.ovirt.org/27093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
