Douglas Schilling Landgraf has posted comments on this change. Change subject: hooks: Adding hooks for ovirt-node-upgrade ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28251/5/Makefile.am File Makefile.am: Line 17 Line 18 Line 19 Line 20 Line 21 > automake should avoid gmake specific syntax. I have inheritance the project, I have been doing improvements on it and your suggestion are good (below as well) and I will implement in different patch since it's not related to this one. http://gerrit.ovirt.org/#/c/28251/5/ovirt-node-plugin-vdsm.spec.in File ovirt-node-plugin-vdsm.spec.in: Line 72: %{recipe_root} Line 73: Line 74: %files Line 75: %{python_sitelib}/ovirt/node/setup/vdsm Line 76: %attr(755, root, root) %{_libexecdir}/ovirt-node/hooks/pre-upgrade/01-vdsm > %attr(755, root, root) should be default, taken from filesystem, if there i Yes, it can replaced but I prefer root, root since it's more explicit. Anyway, I will replace with _SCRIPT. Line 77: %{_sysconfdir}/ovirt-plugins.d Line 78: Line 79: %changelog Line 80: * Fri May 17 2013 Mike Burns <[email protected]> 0.0.2 -- To view, visit http://gerrit.ovirt.org/28251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986fe6edb8f5619dcbca33cccab080245654fd02 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
