Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding resolve groups ......................................................................
Patch Set 2: (6 comments) http://gerrit.ovirt.org/#/c/28368/2/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 126: Authz.QueryEntity.PRINCIPAL Line 127: ).mput( Line 128: Authz.InvokeKeys.RESOLVE_GROUPS_RECURSIVE, Line 129: recursiveGroupsResolving Line 130: ).mput(Authz.InvokeKeys.RESOLVE_GROUPS, > can you please elaborate if there is a scenario in which i would need to se in sync in future you need to query users without recursive and then query groups with recursive. Line 131: recursiveGroupsResolving Line 132: ).mput( Line 133: Authz.InvokeKeys.QUERY_FILTER, Line 134: filter http://gerrit.ovirt.org/#/c/28368/2/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java: Line 47: Line 48: /** Line 49: * Resolve groups. Line 50: * Resolve groups information. Line 51: * */ - Line 52: public static final ExtKey RESOLVE_GROUPS = new ExtKey("AAA_AUTHZ_RESOLVE_GROUPS", Boolean.class, "97d226e9-8d87-49a0-9a7f-af689320907b"); Line 53: Line 54: /** Principal record. */ Line 55: public static final ExtKey PRINCIPAL_RECORD = new ExtKey("AAA_AUTHZ_PRINCIPAL_RECORD", ExtMap.class, "ebc0d5ca-f1ea-402c-86ae-a8ecbdadd6b5"); Line 49: * Resolve groups. Line 50: * Resolve groups information. Line 51: * */ Line 52: public static final ExtKey RESOLVE_GROUPS = new ExtKey("AAA_AUTHZ_RESOLVE_GROUPS", Boolean.class, "97d226e9-8d87-49a0-9a7f-af689320907b"); Line 53: can you please move it before the recursive? Line 54: /** Principal record. */ Line 55: public static final ExtKey PRINCIPAL_RECORD = new ExtKey("AAA_AUTHZ_PRINCIPAL_RECORD", ExtMap.class, "ebc0d5ca-f1ea-402c-86ae-a8ecbdadd6b5"); Line 56: /** Line 57: * AuthResult of operation. Line 114: */ Line 115: public static final ExtUUID FETCH_PRINCIPAL_RECORD = new ExtUUID("AAA_AUTHZ_FETCH_PRINCIPAL_RECORD", "5a5bf9bb-9336-4376-a823-26efe1ba26df"); Line 116: /** Line 117: * Query records. Line 118: * - Line 119: * <p> Line 120: * Input: Line 121: * <ul> Line 122: * <li>{@link InvokeKeys#NAMESPACE}[M]</li> Line 125: * <li>{@link InvokeKeys#RESOLVE_GROUPS_RECURSIVE}[M] - resolve groups recursively.</li> Line 126: * <li>{@link InvokeKeys#RESOLVE_GROUPS}[M] - resolve groups infomration.</li> Line 127: * </ul> Line 128: * </p> Line 129: * - Line 130: * <p> Line 131: * Output: Line 132: * <ul> Line 133: * <li>{@link InvokeKeys#QUERY_OPAQUE}</li> Line 132: * <ul> Line 133: * <li>{@link InvokeKeys#QUERY_OPAQUE}</li> Line 134: * </ul> Line 135: * </p> Line 136: * - Line 137: * <p> Line 138: * Search execute output based on entity. Line 139: * </p> Line 140: */ -- To view, visit http://gerrit.ovirt.org/28368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3249b7f18c8bf609c9577e60aafa948a0aa55101 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
