Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding resolve groups ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28368/2/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 126: Authz.QueryEntity.PRINCIPAL Line 127: ).mput( Line 128: Authz.InvokeKeys.RESOLVE_GROUPS_RECURSIVE, Line 129: recursiveGroupsResolving Line 130: ).mput(Authz.InvokeKeys.RESOLVE_GROUPS, > in sync in future you need to query users without recursive and then query well, while I am thinking about it... 1. login (fetch principal) - groups + recursive. 2. ui search - no groups at all 3. sync - groups (no recursive) why? because you can optimize the sync not to query the same group twice as you can cache groups as you go. thoughts? Line 131: recursiveGroupsResolving Line 132: ).mput( Line 133: Authz.InvokeKeys.QUERY_FILTER, Line 134: filter -- To view, visit http://gerrit.ovirt.org/28368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3249b7f18c8bf609c9577e60aafa948a0aa55101 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
