Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding resolve groups ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/28368/6/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 136: Authz.InvokeKeys.QUERY_ENTITY, Line 137: Authz.QueryEntity.PRINCIPAL Line 138: ).mput( Line 139: Authz.InvokeKeys.QUERY_FLAGS, Line 140: groupsResolving ? Authz.QueryFlags.RESOLVE_GROUPS : Authz.QueryFlags.RESOLVE_GROUPS_NONE why don't you use the neat queryFlagValue(groupsResolving, false) ? Line 141: ).mput( Line 142: Authz.InvokeKeys.QUERY_FILTER, Line 143: filter Line 144: ).mput( -- To view, visit http://gerrit.ovirt.org/28368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3249b7f18c8bf609c9577e60aafa948a0aa55101 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
