Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding resolve groups ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/28368/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java: Line 29: Line 30: DbGroupDAO dao = DbFacade.getInstance().getDbGroupDao(); Line 31: if (groupsSet != null) { Line 32: boolean first = true; Line 33: for (DirectoryGroup group : groupsList) { > The set is unordered, I would like to keep the order of the groups , as I n not that I understand why anything should be ordered... but ok. Line 34: DbGroup dbGroup = dao.getByExternalId(group.getDirectoryName(), group.getId()); Line 35: if (!first) { Line 36: sb.append(","); Line 37: } else { -- To view, visit http://gerrit.ovirt.org/28368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3249b7f18c8bf609c9577e60aafa948a0aa55101 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
