Allon Mureinik has posted comments on this change. Change subject: core: Re-extract validation to be used at the parent command. ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28515/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java: Line 93: super.executeCommand(); Line 94: if (getSucceeded()) { Line 95: if (isImagesAlreadyOnTarget()) { Line 96: getUnregisteredOVFDataDao().removeEntity(ovfEntityData.getEntityId(), Line 97: ovfEntityData.getStorageDomainId()); Unrelated to the patch. Line 98: } else if (!vmDisksToAttach.isEmpty()) { Line 99: AuditLogDirector.log(this, attemptToAttachDisksToImportedVm(vmDisksToAttach)); Line 100: } Line 101: } Line 107: vm.getImages().clear(); Line 108: vm.getDiskList().clear(); Line 109: } Line 110: Line 111: private AuditLogType attemptToAttachDisksToImportedVm(Collection<Disk> disks) { Unrelated to the patch. Line 112: List<String> failedDisks = new LinkedList<>(); Line 113: for (Disk disk : disks) { Line 114: AttachDetachVmDiskParameters params = new AttachDetachVmDiskParameters(getVm().getId(), Line 115: disk.getId(), disk.getPlugged(), disk.getReadOnly()); -- To view, visit http://gerrit.ovirt.org/28515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic25f6f086fe3a8a55de33529a6fb92728d3e0d74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
