Arik Hadas has posted comments on this change. Change subject: core: Re-extract validation to be used at the parent command. ......................................................................
Patch Set 1: Code-Review-1 (1 comment) -1 because of the question regarding NPE In addition, can't we find a 'validator' to extract this method to instead of moving it to the parent? (it does not really belong to the parent imo because it is not related to most of the child commands) http://gerrit.ovirt.org/#/c/28515/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java: Line 164: getVm getVm() won't be null for the import template command? -- To view, visit http://gerrit.ovirt.org/28515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic25f6f086fe3a8a55de33529a6fb92728d3e0d74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
