Liron Ar has posted comments on this change. Change subject: core: long query response time while many simultaneously queries are running ......................................................................
Patch Set 13: (6 comments) http://gerrit.ovirt.org/#/c/27586/13/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAO.java: Line 6: import org.ovirt.engine.core.compat.Guid; Line 7: Line 8: public interface DiskImageDynamicDAO extends GenericDao<DiskImageDynamic, Guid>, MassOperationsDao<DiskImageDynamic, Guid> { Line 9: Line 10: void updateAllWithoutImageId(Collection<DiskImageDynamic> _vmDiskImageDynamicToSave); /s/vmDiskImageDynamicToSave/diskImageDynamic, public access modifier Line 11: http://gerrit.ovirt.org/#/c/27586/13/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java: Line 15: import org.springframework.jdbc.core.RowMapper; Line 16: import org.springframework.jdbc.core.namedparam.MapSqlParameterSource; Line 17: Line 18: public class ImageDaoDbFacadeImpl extends DefaultGenericDaoDbFacade<Image, Guid> implements ImageDao { Line 19: private static final Log log = LogFactory.getLog(ImageDaoDbFacadeImpl.class); not related to this change, please remove when rebasing Line 20: Line 21: public ImageDaoDbFacadeImpl() { Line 22: super("Image"); Line 23: } http://gerrit.ovirt.org/#/c/27586/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1617: } Line 1618: } Line 1619: Line 1620: private void updateRepository(List<Guid> staleRunningVms) { Line 1621: // Preload all disks and their image ID for all running VMs please remove Line 1622: for (VmInternalData vmInternalData : _runningVms.values()) { Line 1623: VmDynamic runningVm = vmInternalData.getVmDynamic(); Line 1624: VM vmToUpdate = _vmDict.get(runningVm.getId()); Line 1625: http://gerrit.ovirt.org/#/c/27586/13/packaging/dbscripts/disk_image_dynamic_sp.sql File packaging/dbscripts/disk_image_dynamic_sp.sql: Line 45: END; $procedure$ Line 46: LANGUAGE plpgsql; Line 47: Line 48: Line 49: Create or replace FUNCTION Updatedisk_image_dynamic_by_disk_id(v_image_id UUID, /s/v_image_id/v_image_group_id Line 50: v_read_rate INTEGER , Line 51: v_write_rate INTEGER , Line 52: v_actual_size BIGINT , Line 53: v_read_latency_seconds numeric(18,9) , Line 58: --The [disk_image_dynamic] table doesn't have a timestamp column. Optimistic concurrency logic cannot be generated Line 59: AS $procedure$ Line 60: BEGIN Line 61: UPDATE disk_image_dynamic Line 62: SET read_rate = v_read_rate,write_rate = v_write_rate,actual_size = v_actual_size,read_latency_seconds = v_read_latency_seconds,write_latency_seconds = v_write_latency_seconds,flush_latency_seconds = v_flush_latency_seconds, _update_date = LOCALTIMESTAMP consider use the update stored procedure to avoid the duplication. Line 63: WHERE image_id in (SELECT distinct image_guid Line 64: FROM images Line 65: WHERE image_group_id = v_image_id and active = true); Line 66: END; $procedure$ http://gerrit.ovirt.org/#/c/27586/13/packaging/dbscripts/images_sp.sql File packaging/dbscripts/images_sp.sql: Line 191 Line 192 Line 193 Line 194 Line 195 can be removed when you rebase -- To view, visit http://gerrit.ovirt.org/27586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
