Liron Ar has posted comments on this change. Change subject: core: long query response time while many simultaneously queries are running ......................................................................
Patch Set 15: Code-Review+1 (1 comment) looks good to me, marking +1 only so there will be another pair of eyes on that :) http://gerrit.ovirt.org/#/c/27586/15/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 187: } Line 188: Line 189: getDbFacade().getVmNetworkStatisticsDao().updateAllInBatch(allVmInterfaceStatistics); Line 190: Line 191: getDbFacade().getDiskImageDynamicDao().updateAllWithoutImageId(_vmDiskImageDynamicToSave); sorry for not noticing before, but i'd rename to clearer name (updateDiskImageDynamicWithIdOfDisk) or something like that. anyway, you can also leave as is as far as i concern. Line 192: getDbFacade().getLunDao().updateAllInBatch(vmLunDisksToSave); Line 193: saveVmDevicesToDb(); Line 194: saveVmGuestAgentNetworkDevices(); Line 195: getVdsEventListener().addExternallyManagedVms(_externalVmsToAdd); -- To view, visit http://gerrit.ovirt.org/27586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
