Daniel Erez has posted comments on this change. Change subject: core: move getNewMaster in ReconstructMasterDomain ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28444/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java: Line 185: changeStorageDomainStatusInTransaction(map, Line 186: getParameters().isInactive() ? StorageDomainStatus.Locked : StorageDomainStatus.PreparingForMaintenance); Line 187: Line 188: final StorageDomain newMaster = electNewMaster(); Line 189: final Guid newMasterId = newMaster != null ? newMaster.getId() : Guid.Empty; shouldn't it be encapsulated instead? i.e. similar to 'getNewMasterId' in http://gerrit.ovirt.org/#/c/28442/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java Line 190: Line 191: proceedStorageDomainTreatmentByDomainType(newMaster, true); Line 192: Line 193: if (_isLastMaster) { -- To view, visit http://gerrit.ovirt.org/28444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30d342a4c5802cdfbf2c78b50dad4c797c137fe2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
