Daniel Erez has posted comments on this change. Change subject: core: move getNewMaster in ReconstructMasterDomain ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28444/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java: Line 34: @NonTransactiveCommandAttribute(forceCompensation = true) Line 35: public class ReconstructMasterDomainCommand<T extends ReconstructMasterParameters> extends Line 36: DeactivateStorageDomainCommand<T> { Line 37: Line 38: protected StorageDomain _newMaster; probably can remove the '_' prefix... Line 39: Line 40: protected Guid _newMasterStorageDomainId = Guid.Empty; Line 41: Line 42: protected boolean canChooseInactiveDomainAsMaster; Line 36: DeactivateStorageDomainCommand<T> { Line 37: Line 38: protected StorageDomain _newMaster; Line 39: Line 40: protected Guid _newMasterStorageDomainId = Guid.Empty; same Line 41: Line 42: protected boolean canChooseInactiveDomainAsMaster; Line 43: Line 44: protected boolean canChooseCurrentMasterAsNewMaster; -- To view, visit http://gerrit.ovirt.org/28444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30d342a4c5802cdfbf2c78b50dad4c797c137fe2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
