Maor Lipchuk has posted comments on this change. Change subject: core: Validate MSD when importing a VM from configuration ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28538/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 621: return true; Line 622: } Line 623: Line 624: protected Guid getSourceDomainId(DiskImage image) { Line 625: return getParameters().getSourceDomainId(); > I really dislike this method... This method is extracted since in export domain we always have one source domain. But when importing a VM with multiple Storage Domains we have multiple source Storage Domain for each disk Line 626: } Line 627: Line 628: protected boolean checkImagesGUIDsLegal() { Line 629: for (DiskImage image : getVm().getImages()) { -- To view, visit http://gerrit.ovirt.org/28538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I067b6186c2a2b7d77394e9cb0a4e8f023c168e4b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
