Liron Ar has posted comments on this change. Change subject: core: Validate MSD when importing a VM from configuration ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28538/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java: Line 157: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_OVF_CONFIGURATION_NOT_SUPPORTED); Line 158: } Line 159: Line 160: for (DiskImage image : getImages()) { Line 161: setStorageDomainId(image.getStorageIds().get(0)); we'll have an issue here with templates with disk copies, please remember to file a bug for that. Line 162: if (!validate(new StorageDomainValidator(getStorageDomain()).isDomainExistAndActive())) { Line 163: return false; Line 164: } Line 165: } Line 170: } Line 171: return true; Line 172: } Line 173: Line 174: protected List<DiskImage> getImages() { implement it as an abstract method if you want it to be implemented by the inhertiging commands, otherwise its error prone. Line 175: return null; Line 176: } Line 177: Line 178: protected boolean isImagesAlreadyOnTarget() { -- To view, visit http://gerrit.ovirt.org/28538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I067b6186c2a2b7d77394e9cb0a4e8f023c168e4b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
