Liron Ar has posted comments on this change. Change subject: db, core: aggregate qos and storage qos impl ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/27094/7/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 188: put(VmInit.class, VmInitDAO.class); Line 189: put(CpuStatistics.class, VdsCpuStatisticsDAO.class); Line 190: put(VdsNumaNode.class, VdsNumaNodeDAO.class); Line 191: put(VmNumaNode.class, VmNumaNodeDAO.class); Line 192: put(StorageQos.class, StorageQosDao.class); > http://gerrit.ovirt.org/#/c/27094/6/backend/manager/modules/dal/src/main/ja Right now compensation isn't used, so it's irrelevant. If it will be decided that compensation for that object is needed you'll need to implement the interface and add changes to the command to use compensation, so right now it's redundant..if we'll add the use of it we'll add it to the map then. Line 193: } Line 194: }; Line 195: Line 196: private JdbcTemplate jdbcTemplate; -- To view, visit http://gerrit.ovirt.org/27094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d63b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
