Michael Pasternak has posted comments on this change. Change subject: restapi: RSDL: Support Links With Optional Body ......................................................................
Patch Set 1: (6 inline comments) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 2440: <xs:sequence> white space Line 2448: </xs:element> white space .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml Line 6: required: false not sure there's a lot of sense in marking Links with "parameterType: null" as "required: false" - it is obvious., i think only use-case for using (required) is "required: false" is when body != null and there is another URI for same link (with no body) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java Line 549: * first is has no knowledge of the second yet, so it must create both linke. links Line 582: return link1; why deleting link1 here? it's more specific!, it has body ... Line 585: return link2; why deleting link2 here? it's more specific!, it has body ... -- To view, visit http://gerrit.ovirt.org/5590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbd87e00ed8eab714229cdf4b830c7fd1bf61f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
