Ori Liel has posted comments on this change. Change subject: restapi: RSDL: Support Links With Optional Body ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml Line 6: required: false but not explicitly giving 'required' a value makes it null, which for boolean defaults to false. It's counter-intuitive to treat null boolean as true. So we'd have to rename it from 'required' (default=true) to something like 'expendable' (then default can be false) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java Line 582: return link1; I tested and remember seeing the right link, but it's possible that it was the wrong one after all. I admit it does look wrong here. Thanks for the comment and the sharp eye; I'll revisit and make sure everything is ok. -- To view, visit http://gerrit.ovirt.org/5590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbd87e00ed8eab714229cdf4b830c7fd1bf61f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
