Martin Peřina has posted comments on this change. Change subject: kdump: Fix kexec-tools dependency for RHEL 7 ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29047/1/src/plugins/ovirt-host-deploy/core/offlinepackager.py File src/plugins/ovirt-host-deploy/core/offlinepackager.py: Line 81: major_version = 0 Line 82: if ( Line 83: ( Line 84: name in ('redhat', 'centos') and Line 85: major_version >= 6 > so you can remove this condition, there aren't any rhel 5 out there, and an Done Line 86: ) or ( Line 87: name == 'fedora' and Line 88: major_version >= 20 Line 89: ) http://gerrit.ovirt.org/#/c/29047/1/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 86: ) Line 87: Line 88: min_version = None Line 89: if name in ('redhat', 'centos'): Line 90: major = version.split('.')[0] > while you at it... split('.', 1) will be more efficient,. Done Line 91: if major == '6': Line 92: min_version = '2.0.0-274' Line 93: elif major == '7': Line 94: min_version = '2.0.4-33' -- To view, visit http://gerrit.ovirt.org/29047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898ba2ef1f4ab38253892e78e83443e8bf36eac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
