Alona Kaplan has posted comments on this change. Change subject: webadmin: Added shared MAC pools to configure dialog ......................................................................
Patch Set 11: (4 comments) http://gerrit.ovirt.org/#/c/27791/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java: Line 92: model.setTitle(ConstantsManager.getInstance().getConstants().editSharedMacPoolTitle()); Line 93: model.setHashName("edit_shared_mac_pool"); //$NON-NLS-1$ Line 94: model.setHelpTag(HelpTag.edit_shared_mac_pool); Line 95: setWindow(model); Line 96: model.setEntity((MacPool) getSelectedItem()); Why is setEntity after setting (and showing) the window? Line 97: } Line 98: Line 99: private void removeMacPools() { Line 100: ConfirmationModel model = new ConfirmationModel(); Line 110: tempVar2.setTitle(ConstantsManager.getInstance().getConstants().cancel()); Line 111: tempVar2.setIsCancel(true); Line 112: model.getCommands().add(tempVar2); Line 113: Line 114: setConfirmWindow(model); Same as the previous comment. Why do you set and show the window before you set the items? Line 115: Line 116: List<String> macPoolNames = new ArrayList<String>(); Line 117: for (MacPool macPool : (Iterable<MacPool>) getSelectedItems()) { Line 118: macPoolNames.add(macPool.getName()); http://gerrit.ovirt.org/#/c/27791/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolModel.java: Line 66: getName What about the description validation? AsciiOrNoneValidation or something of that type. http://gerrit.ovirt.org/#/c/27791/11/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml: Line 47: < Please format -- To view, visit http://gerrit.ovirt.org/27791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idabfa4e2abd3c9f0b4af0d28f00a27aa92a6552f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
