Alona Kaplan has posted comments on this change. Change subject: webadmin: Added shared MAC pools to configure dialog ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/27791/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java: Line 111: tempVar2.setTitle(ConstantsManager.getInstance().getConstants().cancel()); Line 112: tempVar2.setIsCancel(true); Line 113: model.getCommands().add(tempVar2); Line 114: Line 115: setConfirmWindow(model); eeem? You still set the window before you set the items. Line 116: Line 117: List<String> macPoolNames = new ArrayList<String>(); Line 118: for (MacPool macPool : (Iterable<MacPool>) getSelectedItems()) { Line 119: macPoolNames.add(macPool.getName()); http://gerrit.ovirt.org/#/c/27791/12/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml: Line 48: t I"m not sure why, but the new view still shows it unformatted. -- To view, visit http://gerrit.ovirt.org/27791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idabfa4e2abd3c9f0b4af0d28f00a27aa92a6552f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
