Tal Nisan has posted comments on this change. Change subject: aaa: more fixes to command context propgation ......................................................................
Patch Set 12: Code-Review+2 (1 comment) Looks ok to me, given the +1 by Alon, Arik, Moti & Oved I'm giving +2 Please check my comment concerning ImportRepoImageCommand.java, this change is redundant and doesn't belong in this patch (or at all) http://gerrit.ovirt.org/#/c/29290/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java: Line 2: Line 3: import java.util.ArrayList; Line 4: import java.util.Arrays; Line 5: import java.util.List; Line 6: import java.util.Map; This has nothing to do with the patch and redundant, please remove this file from the patch Line 7: Line 8: import org.ovirt.engine.core.bll.provider.OpenStackImageException; Line 9: import org.ovirt.engine.core.bll.provider.OpenStackImageProviderProxy; Line 10: import org.ovirt.engine.core.bll.provider.ProviderProxyFactory; -- To view, visit http://gerrit.ovirt.org/29290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9e0216c83d981d11bb2d8d2a939fd2a279d9d Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
