Moti Asayag has posted comments on this change. Change subject: aaa: more fixes to command context propgation ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/29290/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java: Line 517: public static CommandContext createInternalJobContext(CommandContext commandContext, EngineLock lock) { Line 518: return modifyContextForIntenrakJob(commandContext.clone(), lock); Line 519: } Line 520: Line 521: private static CommandContext modifyContextForIntenrakJob(CommandContext returnedContext, EngineLock lock) { s/modifyContextForIntenrakJob/modifyContextForIntenralJob Line 522: ExecutionContext executionContext = createMonitoredExecutionContext(); Line 523: return returnedContext Line 524: .withExecutionContext(executionContext) Line 525: .withLock(lock) Line 518: return modifyContextForIntenrakJob(commandContext.clone(), lock); Line 519: } Line 520: Line 521: private static CommandContext modifyContextForIntenrakJob(CommandContext returnedContext, EngineLock lock) { Line 522: ExecutionContext executionContext = createMonitoredExecutionContext(); you can inline the call to createMonitoredExecutionContext() (which was part of the reason for extracting it to a method). Line 523: return returnedContext Line 524: .withExecutionContext(executionContext) Line 525: .withLock(lock) Line 526: .withoutCompensationContext(); -- To view, visit http://gerrit.ovirt.org/29290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9e0216c83d981d11bb2d8d2a939fd2a279d9d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
