Martin Peřina has posted comments on this change. Change subject: kdump: Fix kexec-tools detection in node ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29283/1/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 112: if self.environment[odeploycons.VdsmEnv.OVIRT_NODE]: Line 113: # in node rpm -q has to be called to get kexec-tools version Line 114: # instead of standard packager Line 115: available = [] Line 116: rpmCmd = self.command.get('rpm', optional=True) > void logic should be removed, it won't help anything... just cause potentia Now tell me what's better in case that sysadmin created custom ovirt node distribution with old kexec-tools package or without it at all: 1) If we display him message during installation, that kdump detection is not supported, but host installation will be successful 2) Or installation will fail due to unknown parameter when we will restart kdump service Line 117: if rpmCmd is not None: Line 118: (rc, stdout, stderr) = self.execute( Line 119: ( Line 120: self.command.get('rpm'), -- To view, visit http://gerrit.ovirt.org/29283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I136469c35e7fc11d3eb89ab5b4fc71395010f42b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
