Alon Bar-Lev has posted comments on this change. Change subject: kdump: Fix kexec-tools detection in node ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/29283/3/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 113: return ( Line 114: # oVirt Node Line 115: LooseVersion('3.0.5') <= ver < LooseVersion('6') or Line 116: # RHEVH Line 117: ver >= LooseVersion('6.6') can we use single method to check version? rpmutils? Line 118: ) Line 119: Line 120: def _get_available_kexec_tools_versions(self): Line 121: versions = [] Line 140: "%{VERSION} %{RELEASE}", Line 141: self._KEXEC_TOOLS_PKG Line 142: ), Line 143: raiseOnError=False Line 144: ) please so not use rpm just ovirt-node/rhev-h version. Line 145: if rc == 0: Line 146: version_release = stdout[0].split(' ') Line 147: versions.append( Line 148: ( -- To view, visit http://gerrit.ovirt.org/29283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I136469c35e7fc11d3eb89ab5b4fc71395010f42b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
