Allon Mureinik has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
I think you forgot to git add AttachDiskToVmCommandTest.
Also, see inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 165: protected SnapshotDao getSnapshotDao() {
Go over the classes that extend AbstractDiskCommand and remove this method from
them.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 32: private Disk disk;
why did you remove the final modifier from the disk?
Not that I'm a big fan of final, just interested?
Line 36: disk = loadDiskById((Guid) getParameters().getEntityId());
why not call this(parameters, loadDiskById((Guid)
getParameters().getEntityId())?
....................................................
Commit Message
Line 12: wasn't setted to the disk which caused errors when trying to delete a
s/setted/set/
Also, add a comma or something before the which - this sentence is a bit hard
to read.
--
To view, visit http://gerrit.ovirt.org/5718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0945cecc63dc041fdb56e2fd7b733b287a9904c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
