Liron Aravot has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
......................................................................
Patch Set 2: (3 inline comments)
replied to comments by amureini
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 165: protected SnapshotDao getSnapshotDao() {
will do.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 32: private Disk disk;
wanted to remove the dao call from ctor, so i had to remove it because the
final member had to be initiated through the ctor. will be returned.
Line 36: disk = loadDiskById((Guid) getParameters().getEntityId());
the call you wrote isn't legit because it uses instance methods of objects that
weren't initiated yet (super() wasn't called yet) so it won't compile.
I could call this(parameters,null) and check there if the disk is null and than
load it - but it's kind of unnecessary as the two params c'tor will be
basically used only by the test class.
--
To view, visit http://gerrit.ovirt.org/5718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0945cecc63dc041fdb56e2fd7b733b287a9904c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
