Martin Mucha has posted comments on this change. Change subject: core: pool per DC ......................................................................
Patch Set 35: (1 comment) one more comment. http://gerrit.ovirt.org/#/c/26799/35/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolPerDc.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolPerDc.java: Line 33: static final String POOL_TO_BE_REMOVED_DOES_NOT_EXIST_EXCEPTION_MESSAGE = Line 34: "Trying to removed pool which does not exist."; Line 35: Line 36: //package local & non final for testing Line 37: static MacPoolPerDc INSTANCE = new MacPoolPerDc(); > ok, I'll do it. Just to be correct: this will eliminate need to allow acces plus of course testing of commands which adds/modify/remove pools will have to remain same — since that requires access via that singleton. There's OO solution is introduce level of indirection, to split apart pool and it's identification, so there would be object which identifies pool and allow manipulation with it (creation/modification/obtaining pool). Line 38: Line 39: Line 40: private static final Log LOGGER = LogFactory.getLog(MacPoolPerDc.class); Line 41: protected final Map<Guid, MacPoolManagerStrategy> macPools = new HashMap<>(); -- To view, visit http://gerrit.ovirt.org/26799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If522a0b0d5f810281bed010b46b5242f7dbdcc29 Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
