Mike Kolesnik has posted comments on this change. Change subject: core: pool per DC ......................................................................
Patch Set 35: (1 comment) http://gerrit.ovirt.org/#/c/26799/35/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/MacPoolPerDcTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/MacPoolPerDcTest.java: Line 206: errorCollector.checkThat("provided mac should be used in returned pool", MacPoolPerDc.INSTANCE.poolForVmNic(vmNic2).isMacInUse(macAddress2), is(true)); Line 207: } Line 208: Line 209: @Test Line 210: public void testCanRemovePoolWhichIsNotInUse() throws Exception { > I have no idea what do you mean by "in this class context" means. MacPoolPerDc.removePool() just removes it from the internal map in memory and doesn't do any checks, so not sure what you expect. Given the current behavior this test is not necessary. Line 211: //mock data center Line 212: final MacPool macPool1 = createMacPool("00:1a:4a:15:c0:00", "00:1a:4a:15:c0:09"); Line 213: final StoragePool storagePool1 = createStoragePool(macPool1); Line 214: -- To view, visit http://gerrit.ovirt.org/26799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If522a0b0d5f810281bed010b46b5242f7dbdcc29 Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
