Gilad Chaplik has posted comments on this change. Change subject: db, core: Introduce BaseProfile and DiskProfile ......................................................................
Patch Set 12: (2 comments) patch to follow http://gerrit.ovirt.org/#/c/27099/12/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 203: put(ExternalVariable.class, ExternalVariableDao.class); Line 204: put(VdsKdumpStatus.class, VdsKdumpStatusDao.class); Line 205: put(VmJob.class, VmJobDao.class); Line 206: put(StorageQos.class, StorageQosDao.class); Line 207: put(DiskProfile.class, DiskProfileDao.class); > unneeded while it doens't support compensation Done Line 208: } Line 209: }; Line 210: Line 211: private JdbcTemplate jdbcTemplate; http://gerrit.ovirt.org/#/c/27099/12/packaging/dbscripts/upgrade/03_05_0730_add_disk_profiles_table.sql File packaging/dbscripts/upgrade/03_05_0730_add_disk_profiles_table.sql: Line 2: -- table disk_profiles Line 3: --------------------------------------------------------------------- Line 4: CREATE TABLE disk_profiles Line 5: ( Line 6: id UUID NOT NULL CONSTRAINT pk_disk_profiles_id PRIMARY KEY, > please change to PRIMARY KEY, Done. Line 7: name VARCHAR(50) NOT NULL, Line 8: storage_domain_id UUID NOT NULL, Line 9: qos_id UUID, Line 10: description TEXT, -- To view, visit http://gerrit.ovirt.org/27099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229af59277b5055453188f002f19046cdd51d63b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
