Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Protocol decision based on cluser compatibility version ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29123/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java: Line 214: if (Version.v3_5.compareTo(cluster.getcompatibility_version()) <= 0) { Line 215: vdsStatic.setProtocol(VdsProtocol.STOMP); Line 216: } Line 217: } Line 218: } > This kind of logic shouldn't go in the RESTAPI, but in the backend. The RES Done Line 219: Line 220: Host addHostedEngineIfConfigured(Host host, VDS entity) { Line 221: /* Add entity data only if the hosted engine agent is configured on this host */ Line 222: if (entity.getHighlyAvailableIsConfigured()) { -- To view, visit http://gerrit.ovirt.org/29123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
