Tomas Jelinek has posted comments on this change. Change subject: jsonrpc: Protocol decision based on cluser compatibility version ......................................................................
Patch Set 2: Code-Review+1 (1 comment) FE seems OK http://gerrit.ovirt.org/#/c/29123/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 675: Line 676: clusterChanging = false; Line 677: } Line 678: }); Line 679: > By design we do not let users modify protocol for installed host. Yes. it i ok Line 680: hostModel.getCluster().getSelectedItemChangedEvent().addListener(new IEventListener() { Line 681: Line 682: @Override Line 683: public void eventRaised(Event ev, Object sender, EventArgs args) { -- To view, visit http://gerrit.ovirt.org/29123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
