Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Protocol decision based on cluser compatibility version ......................................................................
Patch Set 4: Hi Use still haven't used the correct approach to handle that. You need to create a new config value with the value STOMP/XMLRPC for each version. See http://gerrit.ovirt.org/#/c/25476/ for an example containing a boolean. Thus, instead of having a piece of code that compares the version, you use the configuration mechanism to do that. -- To view, visit http://gerrit.ovirt.org/29123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
