Gilad Chaplik has posted comments on this change. Change subject: db, core: aggregate qos and storage qos impl ......................................................................
Patch Set 17: (2 comments) new patch to follow (soon) http://gerrit.ovirt.org/#/c/27094/17/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java: Line 45: Line 46: @Test Line 47: public void updateStorageQos() { Line 48: StorageQos storageQos = dao.get(FixturesTool.QOS_ID_2); Line 49: assertNotNull(storageQos); > thanks! used assetThat. assertThat(storageQos, not(equalTo(dao.get(FixturesTool.QOS_ID_2)))); Line 50: storageQos.setName("newB"); Line 51: storageQos.setDescription("If I owned a company, my employees would love me. They’d have huge pictures of me up the walls and in their home, like Lenin."); Line 52: storageQos.setMaxThroughput(30); Line 53: storageQos.setMaxReadThroughput(30); Line 80: storageQos.setMaxWriteThroughput(200); Line 81: storageQos.setMaxIops(200); Line 82: storageQos.setMaxReadIops(200); Line 83: storageQos.setMaxWriteIops(200); Line 84: assertNull(dao.get(storageQos.getId())); > thanks, if you can please move it to line 75 :) Done Line 85: dao.save(storageQos); Line 86: StorageQos fetched = dao.get(storageQos.getId()); Line 87: assertNotNull(fetched); Line 88: assertEquals(storageQos, fetched); -- To view, visit http://gerrit.ovirt.org/27094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d63b Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
