Lior Vernia has posted comments on this change. Change subject: webadmin: Add MAC pools in DC dialog ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/27792/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java: Line 239: Line 240: if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition) && sender == getStoragePoolType()) { Line 241: storagePoolType_SelectedItemChanged(); Line 242: } else if (sender == getMacPoolListModel()) { Line 243: if (ev.matchesDefinition(ListModel.selectedItemsChangedEventDefinition)) { > The match should be to itemsChangedEventDefinition and not to selectedItems Right, done. Line 244: initSelectedMacPool(); Line 245: } else if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition)) { Line 246: getMacPoolModel().setEntity(getMacPoolListModel().getSelectedItem()); Line 247: } -- To view, visit http://gerrit.ovirt.org/27792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338a5647ded866c6b7b07542e9a95ea3dc3a2594 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
