Alona Kaplan has posted comments on this change. Change subject: webadmin: Add MAC pools in DC dialog ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/27792/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java: Line 324: } Line 325: } Line 326: } Line 327: Line 328: public void initSelectedMacPool() { > You didn't specify which member's setEntity() you were referring to, I thou The change isn't required because the removal of initSelectedMacPool() from DataCenterListModel. As I wrote in DataCenterListModel, initSelectedMacPool() was redundant there. Line 329: Collection<MacPool> allMacPools = getMacPoolListModel().getItems(); Line 330: StoragePool dc = getEntity(); Line 331: if (allMacPools != null && dc != null) { Line 332: Guid macPoolId = dc.getMacPoolId(); -- To view, visit http://gerrit.ovirt.org/27792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338a5647ded866c6b7b07542e9a95ea3dc3a2594 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
