Omer Frenkel has posted comments on this change.
Change subject: core: Reconstruct doesn't not happen if domain is single in pool
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 491:
.masterDomainNotOperational(masterDomainId, storagePoolId, false);
i think we can send true for force here,
if its a sync problem reconstruct can fix it and using the same domain is ok
because the problem is not the domain, just sync..
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/WrongMasterOrVersion.java
Line 3: public class WrongMasterOrVersion extends IRSNoMasterDomainException {
i think it should end with Exception, no?
--
To view, visit http://gerrit.ovirt.org/5743
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7df4f42ccf126b69008ce84cb549c98fe8e98c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
