Ayal Baron has posted comments on this change.

Change subject: core: Reconstruct doesn't not happen if domain is single in pool
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(4 inline comments)

discussed with Michael f2f today and agreed that this should be solved 
differently.
-1 Just to make sure this isn't merged by mistake

....................................................
Commit Message
Line 7: core: Reconstruct doesn't not happen if domain is single in pool
s/not//

Line 9: At case that engine get a 324 error from vdsm : Wrong Master domain or 
its version,
s/At/In/
s/get/gets/

Line 10: reconstruct can be run on the old master, such change at behaviour 
will allow to run reconstruct
s/reconstruct/reconstructMaster/
s/such/this/
s/at/of/
s/to run/running/

Line 11: even if we have only one domain at pool and error is 324
s/at/in/

--
To view, visit http://gerrit.ovirt.org/5743
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7df4f42ccf126b69008ce84cb549c98fe8e98c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to