Yair Zaslavsky has posted comments on this change. Change subject: bll: don't add user if login fails ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29525/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 262: getDbUserDAO().getByExternalId( Line 263: AuthzUtils.getName(profile.getAuthz()), Line 264: directoryUser.getId()); Line 265: HashSet<Guid> groupIds = DirectoryUtils.getGroupIdsFromUser(directoryUser); Line 266: if (dbUser == null) { why do u differentitate here? not sure i understood the motivation of seperation between users with and uses without groups, thanks! Line 267: if (groupIds.isEmpty()) { Line 268: addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DB); Line 269: return false; Line 270: } -- To view, visit http://gerrit.ovirt.org/29525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7434c45a3aca7ed74002f65ab3315e86233e1530 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
