Roy Golan has posted comments on this change.

Change subject: core: enable ConfigValues injection
......................................................................


Patch Set 2: Verified+1

(1 comment)

http://gerrit.ovirt.org/#/c/29539/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DependencyProducers.java
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DependencyProducers.java:

Line 6: import org.ovirt.engine.core.utils.ConfigUtilsBase;
Line 7: 
Line 8: public class DependencyProducers {
Line 9: 
Line 10:     public static class DummyConfig extends Config {
for real integration test I expect out dummy config to read all its config val 
from Properties file or xml json or whatever we want to supply as a source for 
values
Line 11: 
Line 12:         public DummyConfig() {
Line 13:             setConfigUtils(new ConfigUtilsBase() {
Line 14:                 @Override protected void setValue(String name, String 
value, String version) {


-- 
To view, visit http://gerrit.ovirt.org/29539
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63c4d5f6239d5f4fd7737f9637d1a6e999020b1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to